Hi Wolfram,
On Sun, Oct 9, 2022 at 11:20 PM Wolfram Sang <wsa@xxxxxxxxxx> wrote:
> > + DEF_FIXED("sasyncperd1",R8A779G0_CLK_SASYNCPERD1, CLK_SASYNCPER,1, 1),
> > + DEF_FIXED("sasyncperd2",R8A779G0_CLK_SASYNCPERD2, CLK_SASYNCPER,2, 1),
> > + DEF_FIXED("sasyncperd4",R8A779G0_CLK_SASYNCPERD4, CLK_SASYNCPER,4, 1),
>
> Some spaces missing after the commas.
I did it this way to keep the columns a little bit more aligned.
The alternative is to widen the columns, and adds TABs in all rows...
> But my main issue is that we have it a little different for S4-8:
>
> 112 DEF_FIXED("sasyncperd1", R8A779F0_CLK_SASYNCPERD1, CLK_PLL5_DIV4, 3, 1),
> 113 DEF_FIXED("sasyncperd2", R8A779F0_CLK_SASYNCPERD2, R8A779F0_CLK_SASYNCPERD1, 2, 1),
> 114 DEF_FIXED("sasyncperd4", R8A779F0_CLK_SASYNCPERD4, R8A779F0_CLK_SASYNCPERD1, 4, 1),
>
> So, no CLK_SASYNCPER at all because R8A779G0_CLK_SASYNCPERD1 divides
> PLL5 directly. I don't mind which version we use but I think it should
> be consistent because the diagram looks the same in the specs. What do
> you think?
I can add an internal SASYNCPER clock on R-Car S4-8, too.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
