On 5 October 2022 09:44:56 IST, "Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx> wrote: >Hi Conor, > >Thank you for the review. > >On Tue, Oct 4, 2022 at 6:43 PM Conor Dooley <conor@xxxxxxxxxx> wrote: >> > +static void cpu_dcache_wb_range(unsigned long start, >> > + unsigned long end, >> > + int line_size) >> > +{ >> > + bool ucctl_ok = false; >> > + unsigned long pa; >> > + int mhartid = 0; >> > +#ifdef CONFIG_SMP >> > + mhartid = smp_processor_id(); >> > +#endif >> >> Won't this produce complaints from your if you compile with CONFIG_SMP >> set? >> >No I dont see a build issue with SMP enabled, do you see any reason >why it should fail? Not fail but complain about the unused variable.