Hi Rob,
Thank you for your review!
> From: Rob Herring, Sent: Tuesday, September 13, 2022 10:03 PM
>
> On Fri, Sep 09, 2022 at 10:26:11PM +0900, Yoshihiro Shimoda wrote:
> > Document Renesas Etherent Switch for R-Car S4-8 (r8a779f0).
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > ---
> > .../bindings/net/renesas,etherswitch.yaml | 252 ++++++++++++++++++
> > 1 file changed, 252 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/net/renesas,etherswitch.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/net/renesas,etherswitch.yaml
> b/Documentation/devicetree/bindings/net/renesas,etherswitch.yaml
> > new file mode 100644
> > index 000000000000..1affbf208829
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/renesas,etherswitch.yaml
<snip>
> > +title: Renesas Ethernet Switch
> > +
> > +maintainers:
> > + - Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> > +
> > +properties:
> > + compatible:
> > + const: renesas,r8a779f0-ether-switch
> > +
> > + reg:
> > + maxItems: 3
> > +
> > + reg-names:
> > + items:
> > + - const: base
> > + - const: secure_base
> > + - const: serdes
>
> Is serdes really the same h/w block? Based on addresses, doesn't seem
> like it.
You're correct. The serdes is not the same h/w block. I'll fix it somehow.
> > +
> > + interrupts:
> > + maxItems: 47
> > +
> > + interrupt-names:
> > + items:
> > + - const: mfwd_error
> > + - const: race_error
> > + - const: coma_error
> > + - const: gwca0_error
> > + - const: gwca1_error
> > + - const: etha0_error
> > + - const: etha1_error
> > + - const: etha2_error
> > + - const: gptp0_status
> > + - const: gptp1_status
> > + - const: mfwd_status
> > + - const: race_status
> > + - const: coma_status
> > + - const: gwca0_status
> > + - const: gwca1_status
> > + - const: etha0_status
> > + - const: etha1_status
> > + - const: etha2_status
> > + - const: rmac0_status
> > + - const: rmac1_status
> > + - const: rmac2_status
> > + - const: gwca0_rxtx0
> > + - const: gwca0_rxtx1
> > + - const: gwca0_rxtx2
> > + - const: gwca0_rxtx3
> > + - const: gwca0_rxtx4
> > + - const: gwca0_rxtx5
> > + - const: gwca0_rxtx6
> > + - const: gwca0_rxtx7
> > + - const: gwca1_rxtx0
> > + - const: gwca1_rxtx1
> > + - const: gwca1_rxtx2
> > + - const: gwca1_rxtx3
> > + - const: gwca1_rxtx4
> > + - const: gwca1_rxtx5
> > + - const: gwca1_rxtx6
> > + - const: gwca1_rxtx7
> > + - const: gwca0_rxts0
> > + - const: gwca0_rxts1
> > + - const: gwca1_rxts0
> > + - const: gwca1_rxts1
> > + - const: rmac0_mdio
> > + - const: rmac1_mdio
> > + - const: rmac2_mdio
> > + - const: rmac0_phy
> > + - const: rmac1_phy
> > + - const: rmac2_phy
> > +
> > + clocks:
> > + maxItems: 2
> > +
> > + clock-names:
> > + items:
> > + - const: fck
> > + - const: tsn
> > +
> > + resets:
> > + maxItems: 2
>
> What is each one?
"tsn" and "rswitch2". So, I'll add reset-names for it.
> > +
> > + iommus:
> > + maxItems: 16
> > +
> > + power-domains:
> > + maxItems: 1
> > +
> > + '#address-cells':
> > + description: Number of address cells for the MDIO bus.
> > + const: 1
> > +
> > + '#size-cells':
> > + description: Number of size cells on the MDIO bus.
> > + const: 0
>
> It's better if you put MDIO under an 'mdio' node. That also needs a ref
> to mdio.yaml.
I got it.
> > +
> > + ports:
> > + type: object
> > +
> > + properties:
> > + '#address-cells':
> > + const: 1
> > + '#size-cells':
> > + const: 0
> > +
> > + additionalProperties: false
> > +
> > + patternProperties:
> > + "^port@[0-9a-f]+$":
> > + type: object
> > +
> > + $ref: "/schemas/net/ethernet-controller.yaml#"
> > + unevaluatedProperties: false
> > +
> > + properties:
> > + '#address-cells':
> > + const: 1
> > + '#size-cells':
> > + const: 0
> > +
> > + reg:
> > + description:
> > + Switch port number
> > +
> > + phy-handle:
> > + description:
> > + Phandle of an Ethernet PHY.
> > +
> > + phy-mode:
> > + description:
> > + This specifies the interface used by the Ethernet PHY.
> > + enum:
> > + - mii
> > + - sgmii
> > + - usxgmii
> > +
> > + required:
> > + - reg
> > + - phy-handle
> > + - phy-mode
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - reg-names
> > + - interrupts
> > + - interrupt-names
> > + - clocks
> > + - clock-names
> > + - resets
> > + - power-domains
> > + - '#address-cells'
> > + - '#size-cells'
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/r8a779f0-cpg-mssr.h>
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > + #include <dt-bindings/power/r8a779f0-sysc.h>
> > +
> > + rswitch: ethernet@e6880000 {
>
> Drop unused labels.
I'll drop it.
Best regards,
Yoshihiro Shimoda
