Hi Sergey Shtylyov,
Thanks for the feed back.
> Subject: Re: [PATCH net-next v2] ravb: Add RZ/G2L MII interface support
>
> On 9/12/22 1:51 PM, Biju Das wrote:
>
> > EMAC IP found on RZ/G2L Gb ethernet supports MII interface.
> > This patch adds support for selecting MII interface mode.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> [...]
>
> > diff --git a/drivers/net/ethernet/renesas/ravb.h
> > b/drivers/net/ethernet/renesas/ravb.h
> > index b980bce763d3..0c7c0d404dcb 100644
> > --- a/drivers/net/ethernet/renesas/ravb.h
> > +++ b/drivers/net/ethernet/renesas/ravb.h
> [...]
> > @@ -965,6 +966,10 @@ enum CXR31_BIT {
> > CXR31_SEL_LINK1 = 0x00000008,
> > };
> >
> > +enum CXR35_BIT {
> > + CXR35_SEL_MII = 0x03E80002,
>
> I'd really prefer that SEL_XMII[1:0] and HALFCYC_CLKSW[15:0] fields to
> be explicitly spelled out here (as they are in the manual)...
OK , will add CXR35_HALFCYC_CLKSW_1000 and CXR35_SEL_XMII_MII.
Cheers,
Biju
