Re: [PATCH v2 1/3] media: dt-bindings: media: renesas,fcp: Document RZ/{G2,V2}L FCPVD bindings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 31/08/2022 18:32, Biju Das wrote:
>>>  properties:
>>>    compatible:
>>> -    enum:
>>> -      - renesas,fcpv # FCP for VSP
>>> -      - renesas,fcpf # FCP for FDP
>>> +    oneOf:
>>> +      - items:
>>
>> No items here. You have just one item, so it is not a list.
> 
> So you mean, it should be like below.
> Can you please confirm my understanding is correct?
> 
> oneOf:
>    - enum:
>        - renesas,fcpv # FCP for VSP
>        - renesas,fcpf # FCP for FDP
>     - items:
>         - enum:
>             - renesas,r9a07g044-fcpvd # RZ/G2{L,LC}
>             - renesas,r9a07g054-fcpvd # RZ/V2L
>             - const: renesas,fcpv   # generic FCP for VSP fallback

Yes

> 
> 
>>> +              - renesas,fcpv # FCP for VSP
>>> +              - renesas,fcpf # FCP for FDP
>>
>>> +          - enum:
>>> +              - renesas,fcpv # FCP for VSP
>>> +              - renesas,fcpf # FCP for FDP
>>> +
>>> +      - items:
>>> +          - enum:
>>> +              - renesas,r9a07g044-fcpvd # RZ/G2{L,LC}
>>> +              - renesas,r9a07g054-fcpvd # RZ/V2L
>>> +          - const: renesas,fcpv   # generic FCP for VSP fallback
>>>
>>>    reg:
>>>      maxItems: 1
>>>
>>> -  clocks:
>>> -    maxItems: 1
>>> +  clocks: true
>>> +  clock-names: true
>>
>> Both should have here the widest constraints: minItems:1 and maxItems:3.
> 
> It is taken care in conditional schema right?
> 
> It is same as [1], where wider people including you added Rb tag. 

Yeah, it's fine.

Best regards,
Krzysztof



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux