Hi Laurent, Thanks for the feedback. > Subject: Re: [PATCH v6 2/2] drm: rcar-du: Add RZ/G2L DSI driver > > Hi Biju, > > On Mon, Aug 29, 2022 at 04:26:02PM +0000, Biju Das wrote: > > Hi Robert, > > > > Thanks for the feedback. > > > > > Subject: Re: [PATCH v6 2/2] drm: rcar-du: Add RZ/G2L DSI driver > > > > > > Hey Biju, > > > > > > The patch does not apply on drm-misc-next, could you rebase it and > > > submit the next version? > > > > I believe[1] is dependent on this patch series. Sorry for not making > > it clear while sending this patch series out. > > > > I thought Laurent is going to give a pull request for RCar DU patches. > > That's right. The patches apply fine to my branch. > > > Based on that assumption, currently my environment is drm-tip + > > 12 patches from[2], as [2] doesn't have all the latest patches from > > drm-misc-next/drm-tip. > > > > > > > Additionally it has a few 'checkpatch --strict' warnings. > > > > I got a review comment[3] to use (1 << 1) style instead of BIT macro. > > Some of the warnings related to this. > > > > Laurent, any thoughts?? > > (1 << x) instead of BIT it correct when the field stores a value, not a > single bit flag. OK, then it is fine. Cheers, Biju
