Hi Morimoto-san, On Tue, Aug 23, 2022 at 3:26 AM Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> wrote: > From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> > > This patch adds r8a77980A V3H2 (= r8a77980 ES2) Condor-I board > basic support. > > Signed-off-by: Andrey Dolnikov <andrey.dolnikov@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Valentine Barshak <valentine.barshak@xxxxxxxxxxxxxxxxxx> > Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@xxxxxxxxxxx> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx> Thanks for your patch! > --- /dev/null > +++ b/arch/arm64/boot/dts/renesas/r8a77980a-condor-i.dts > @@ -0,0 +1,17 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + * Device Tree Source for the Condor-I board on r8a77980A (ES2.0) > + * > + * Copyright (C) 2022 Renesas Electronics Corp. > + */ > + > +/dts-v1/; > +#include "r8a77980a.dtsi" > +#include "condor-common.dtsi" > + > +/ { > + model = "Renesas Condor-I board based on r8a77980A (ES2.0)"; > + No need for a blank line. > + compatible = "renesas,condor-i", "renesas,condor", > + "renesas,r8a77980a", "renesas,r8a77980"; Please drop compatibility with "renesas,condor", as per my comment on "[PATCH v2 4/4] dt-bindings: arm: renesas: Document Renesas R-Car Gen3 V3H2 Condor-I board". > +}; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds