Re: [PATCH v2 4/4] dt-bindings: arm: renesas: Document Renesas R-Car Gen3 V3H2 Condor-I board

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Morimoto-san,

On Tue, Aug 23, 2022 at 3:27 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> This patch adds new R-Car Gen3 V3H2 Condor-I board.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>

Thanks for your patch!

> --- a/Documentation/devicetree/bindings/arm/renesas.yaml
> +++ b/Documentation/devicetree/bindings/arm/renesas.yaml
> @@ -291,6 +291,15 @@ properties:
>                - renesas,v3hsk # V3HSK (Y-ASK-RCAR-V3H-WS10)
>            - const: renesas,r8a77980
>
> +      - description: R-Car V3H2 (R8A77980A)
> +        items:
> +          - enum:
> +              - renesas,condor-i # Condor-I (RTP0RC77980SEBS012SA01)
> +          - enum:
> +              - renesas,condor   # Condor

Given the changes in the PMIC and CAN transceiver department, I think
it would be prudent to drop the compatibility with "renesas,condor".

For similar reasons, the Salvator-XS board also doesn't declare
compatibility with "renesas,salvator-x".

> +          - const: renesas,r8a77980a
> +          - const: renesas,r8a77980
> +
>        - description: R-Car E3 (R8A77990)
>          items:
>            - enum:

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux