Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH v12 2/5] media: renesas: vsp1: Add support to
> deassert/assert reset line
>
> Hi Biju,
>
> On Fri, Jul 22, 2022 at 6:49 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > As the resets DT property is mandatory, and is present in all .dtsi in
> > mainline, add support to perform deassert/assert using reference
> > counted reset handle.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > ---
> > v11->v12:
> > * Replaced read_poll_timeout_atomic-> udelay(1) as testing on RZ/G1N
> > shows this delay is sufficient to avoid lock-up.
> > * Removed Rb tags.
>
> Thanks for the update!
>
> > --- a/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> > +++ b/drivers/media/platform/renesas/vsp1/vsp1_drv.c
> > @@ -11,11 +11,13 @@
> > #include <linux/delay.h>
> > #include <linux/device.h>
> > #include <linux/interrupt.h>
> > +#include <linux/iopoll.h>
>
> This is no longer needed.
Oops, fix it in next version.
Cheers,
Biju
>
> > #include <linux/module.h>
> > #include <linux/of.h>
> > #include <linux/of_device.h>
> > #include <linux/platform_device.h>
> > #include <linux/pm_runtime.h>
> > +#include <linux/reset.h>
> > #include <linux/videodev2.h>
> >
> > #include <media/rcar-fcp.h>
>
> The rest LGTM, so with the above fixed:
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
