Hi Krzysztof, On Wed, Jul 27, 2022 at 11:09 AM Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote: > > On 27/07/2022 12:06, Lad, Prabhakar wrote: > > Hi Krzysztof, > > > > On Wed, Jul 27, 2022 at 10:54 AM Krzysztof Kozlowski > > <krzysztof.kozlowski@xxxxxxxxxx> wrote: > >> > >> On 27/07/2022 11:05, Lad, Prabhakar wrote: > >>> Hi Krzysztof, > >>> > >>> Thank you for the review. > >>> > >>> On Wed, Jul 27, 2022 at 9:54 AM Krzysztof Kozlowski > >>> <krzysztof.kozlowski@xxxxxxxxxx> wrote: > >>>> > >>>> On 26/07/2022 20:06, Lad Prabhakar wrote: > >>>>> Document Renesas RZ/Five (R9A07G043) SoC and SMARC EVK based on this SoC. > >>>>> > >>>>> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > >>>>> --- > >>>>> .../devicetree/bindings/riscv/renesas.yaml | 49 +++++++++++++++++++ > >>>>> 1 file changed, 49 insertions(+) > >>>>> create mode 100644 Documentation/devicetree/bindings/riscv/renesas.yaml > >>>>> > >>>>> diff --git a/Documentation/devicetree/bindings/riscv/renesas.yaml b/Documentation/devicetree/bindings/riscv/renesas.yaml > >>>>> new file mode 100644 > >>>>> index 000000000000..f72f8aea6a82 > >>>>> --- /dev/null > >>>>> +++ b/Documentation/devicetree/bindings/riscv/renesas.yaml > >>>>> @@ -0,0 +1,49 @@ > >>>>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > >>>>> +%YAML 1.2 > >>>>> +--- > >>>>> +$id: http://devicetree.org/schemas/riscv/renesas.yaml# > >>>>> +$schema: http://devicetree.org/meta-schemas/core.yaml# > >>>>> + > >>>>> +title: Renesas RZ/Five Platform Device Tree Bindings > >>>>> + > >>>>> +maintainers: > >>>>> + - Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > >>>>> + - Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > >>>>> + > >>>>> +# We want to ignore this schema if the board is SMARC EVK based on ARM64 arch > >>>>> +select: > >>>>> + not: > >>>>> + properties: > >>>>> + compatible: > >>>>> + contains: > >>>>> + items: > >>>> > >>>> I think you should rather ignore the RiscV SoCs, not specific board. > >>>> > >>> You mean to ignore ARM/64 SoCs? > >>> > >>> Agreed just the below enum, should do the trick. > >>> > >>> - enum: > >>> - renesas,r9a07g043u11 > >>> - renesas,r9a07g043u12 > >>> - renesas,r9a07g044c1 > >>> - renesas,r9a07g044c2 > >>> - renesas,r9a07g044l1 > >>> - renesas,r9a07g044l2 > >>> - renesas,r9a07g054l1 > >>> - renesas,r9a07g054l2 > >>> > >>> > >>>>> + - const: renesas,smarc-evk > >>>>> + - enum: > >>>>> + - renesas,r9a07g043u11 > >>>>> + - renesas,r9a07g043u12 > >>>>> + - renesas,r9a07g044c1 > >>>>> + - renesas,r9a07g044c2 > >>>>> + - renesas,r9a07g044l1 > >>>>> + - renesas,r9a07g044l2 > >>>>> + - renesas,r9a07g054l1 > >>>>> + - renesas,r9a07g054l2 > >>>>> + - enum: > >>>>> + - renesas,r9a07g043 > >>>>> + - renesas,r9a07g044 > >>>>> + - renesas,r9a07g054 > >>>> > >>>> Did you actually test that it works and properly matches? > >>>> > >>> Yes I have run the dtbs_check and dt_binding _check for ARM64 and > >>> RISC-V. Do you see any cases where it can fail? > >> > >> > >> Just remove the renesas,smarc-evk2 from > >> arch/arm64/boot/dts/renesas/r9a07g043u11-smarc.dts. Do you see the > >> error? Not from this schema. The only error you will see is that no > >> matching schema was found. > >> > > I did run the dtbs_check test as per your suggestion (below is the > > log) and didn't see "no matching schema error" > > > > So you do not see any errors at all. Then it does not work, does it? > Right I reverted my changes I can see it complaining, dtb_check seems to have returned false positive in my case. What approach would you suggest to ignore the schema here? Cheers, Prabhakar
