On 7/21/22 12:23, Biju Das wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe > > Hi Tudor Ambarus, > > I have done quick test with these generic patches. Please find my observation > below. Thanks! > >> Subject: Re: [PATCH v2 2/2] mtd: spi-nor: Add Renesas AT25QL128A serial nor >> flash >> >> On 7/15/22 13:57, Biju Das wrote: >> >> Hi, Biju! >> >>> EXTERNAL EMAIL: Do not click links or open attachments unless you know >>> the content is safe >>> >>> Add support for Renesas AT25QL128A serial nor flash. >>> Details of flash chip can be found here [1] >>> >>> [1] >>> >>> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> >>> --- >>> $ xxd -p sfdp >>> 53464450060101ff00060110300000ff1f00010280000001ffffffffffff >>> ffffffffffffffffffffffffffffffffffffe520f1ffffffff0744eb086b >>> 083b80bbfeffffffffff00ffffff42eb0c200f5210d800ff3362d5008429 >>> 01ceeca1073d7a757a75f7a2d55c19f61cffe810c080ffffffffffffffff >>> ffffffffffffffff501650190000ffff >>> >>> $ md5sum >>> /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1 >>> .0/spi-nor/sfdp 23e3ec56b5b8f986d0488ba4727239dd >>> /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1 >>> .0/spi-nor/sfdp $ cat >>> /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1 >>> .0/spi-nor/jedec_id >>> 1f4218 >>> $ cat >>> /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1 >>> .0/spi-nor/partname >>> at25ql128a >>> $ cat >>> /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1 >>> .0/spi-nor/manufacturer >>> atmel > > With generic flash driver patches I get below results > ---------------------------------------------------- > > xxd -p sfdp > 53464450060101ff00060110300000ff1f00010280000001ffffffffffff > ffffffffffffffffffffffffffffffffffffe520f1ffffffff0744eb086b > 083b80bbfeffffffffff00ffffff42eb0c200f5210d800ff3362d5008429 > 01ceeca1073d7a757a75f7a2d55c19f61cffe810c080ffffffffffffffff > ffffffffffffffff501650190000ffff > > This result is same as above. ok, as expected. > > cat /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1.0/spi-nor/jedec_id > 1f42181f4218 > > This result is not matching 1f4218->1f42181f4218 here it looks like the ID is sent twice. > > root@smarc-rzg2ul:~# cat /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1.0/spi-nor/partname > spi-nor-generic > > This result is not matching at25ql128a-> spi-nor-generic right, as expected > > root@smarc-rzg2ul:~# cat /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1.0/spi-nor/manufacturer > cat: /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1.0/spi-nor/manufacturer: No such file or directory > > This result is not matching atmel-> cat: /sys/devices/platform/soc/10060000.spi/rpc-if-spi/spi_master/spi1/spi1.0/spi-nor/manufacturer: No such file or directory here we could introduce a generic name as well. > > How do we get proper partname/manufacturer details with generic flash driver? You don't, as it is you get just generic names like generic-spi-nor and generic-manufacturer. Why do you find the flash/manufacturer names important? ta
