Re: [PATCH 1/3] dt-bindings: timer: renesas,cmt: Add r8a779f0 and generic Gen4 CMT support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Wolfram,

On Tue, Jul 19, 2022 at 9:57 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> On Wed, Jul 13, 2022 at 12:06 PM Wolfram Sang
> <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote:
> > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> > +++ b/Documentation/devicetree/bindings/timer/renesas,cmt.yaml
> > @@ -83,6 +83,11 @@ properties:
> >                - renesas,r8a779a0-cmt0     # 32-bit CMT0 on R-Car V3U
> >            - const: renesas,rcar-gen3-cmt0 # 32-bit CMT0 on R-Car Gen3 and RZ/G2
> >
> > +      - items:
> > +          - enum:
> > +              - renesas,r8a779f0-cmt0     # 32-bit CMT0 on R-Car S4-8
> > +          - const: renesas,rcar-gen4-cmt0 # 32-bit CMT0 on R-Car Gen4
> > +
> >        - items:
> >            - enum:
> >                - renesas,r8a774a1-cmt1     # 48-bit CMT on RZ/G2M
> > @@ -100,6 +105,11 @@ properties:
> >                - renesas,r8a779a0-cmt1     # 48-bit CMT on R-Car V3U
> >            - const: renesas,rcar-gen3-cmt1 # 48-bit CMT on R-Car Gen3 and RZ/G2
> >
> > +      - items:
> > +          - enum:
> > +              - renesas,r8a779f0-cmt1     # 48-bit CMT on R-Car S4-8
> > +          - const: renesas,rcar-gen4-cmt1 # 48-bit CMT on R-Car Gen4
> > +
> >    reg:
> >      maxItems: 1
>
> The above is correct, but you forgot to update the conditional sections
> specifying the number of interrupts.

However, it would have been nice to adhere to the existing sort order
in the file... I will prepare a patch for both issues...

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux