RE: [PATCH 1/2] dt-bindings: usb: renesas, usb3-peri: Document RZ/V2M r9a09g011 support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Krzysztof,

Thanks for your review!

On 18 July 2022 14:55 Krzysztof Kozlowski wrote:
> On 18/07/2022 15:44, Phil Edworthy wrote:
> > Document the RZ/V2M SoC bindings.
> > The RZ/V2M SoC is a little different to the R-Car implementations.
> > A few DRD related registers and bits have moved, there is a separate
> > interrupt for DRD, an additional clock for register access and reset
> > lines for DRD and USBP.
> >
> > Signed-off-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx>
> > Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> >  .../bindings/usb/renesas,usb3-peri.yaml       | 81 +++++++++++++++----
> >  1 file changed, 66 insertions(+), 15 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/usb/renesas,usb3-
> peri.yaml b/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
> > index 9fcf54b10b07..28f785dd2012 100644
> > --- a/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
> > +++ b/Documentation/devicetree/bindings/usb/renesas,usb3-peri.yaml
> > @@ -11,27 +11,49 @@ maintainers:
<snip>

> >    interrupts:
> > -    maxItems: 1
> > +    minItems: 1
> > +    items:
> > +      - description: Combined interrupt for DMA, SYS and ERR
> > +      - description: Dual Role Device (DRD)
> > +
> > +  interrupt-names:
> 
> minItems:1
> 
> > +    items:
> > +      - const: all_p
> > +      - const: drd
> >
> >    clocks:
> > -    maxItems: 1
> > +    minItems: 1
> > +    items:
> > +      - description: Main clock
> > +      - description: Register access clock
> > +
> > +  clock-names:
> 
> minItems:1
> 
> > +    items:
> > +      - const: aclk
> > +      - const: reg
> >
> >    phys:
> >      maxItems: 1
> > @@ -43,7 +65,15 @@ properties:
> >      maxItems: 1
> >
> >    resets:
> > -    maxItems: 1
> > +    minItems: 1
> > +    items:
> > +      - description: Peripheral reset
> > +      - description: DRD reset
> > +
> > +  reset-names:
> > +    items:
> > +      - const: aresetn_p
> > +      - const: drd_reset
> >
> >    usb-role-switch:
> >      $ref: /schemas/types.yaml#/definitions/flag
> > @@ -78,6 +108,27 @@ required:
> >    - interrupts
> >    - clocks
> >
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - renesas,rzv2m-usb3-peri
> > +    then:
> > +      properties:
> > +        clocks:
> > +          minItems: 2
> > +        interrupts:
> > +          minItems: 2
> > +        resets:
> > +          minItems: 2
> > +      required:
> > +        - clock-names
> > +        - interrupt-names
> > +        - resets
> > +        - reset-names
> 
> else:
> narrow the number of items
Sorry, I don't understand why we need minItems: 1 for
interrupt-names/clock-names, but then I'm easily confused!

None of the existing users have any interrupt-names/clock-names
hence they are not in required. The rzv2m is the only device
that needs them so the driver can get them by name, and hence
it sets minItems: 2

Thanks
Phil




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux