On Mon, 2022-07-11 at 15:15 +0200, Andy Shevchenko wrote: > On Mon, Jul 11, 2022 at 2:40 PM Nuno Sá <nuno.sa@xxxxxxxxxx> wrote: > > > > Just cosmetics. No functional change intended... > > ... > > > - if (name == NULL && channel_name == NULL) > > + if (!name && !channel_name) > > return ERR_PTR(-ENODEV); > > After this change in place, I think it's better to convert it to > > if (!(name || channel_name)) > > which shows intentions clearer. > No strong feelings from my side so I can do that if a v3 is needed (which, most likely, will be needed). - Nuno Sá