On 07/07/2022 12:26, Niklas Söderlund wrote:
Hi Daniel,
On 2022-07-07 11:55:55 +0200, Daniel Lezcano wrote:
Thanks for double checking and confirming. I've a patch removing this code,
no need to send one. I'll submit it along with other changes around this.
Perhaps, I'll try a revert before, it would make more sense.
Thanks.
To be clear I don't think we should revert commit 47cf09e0f4fc5120
("thermal/drivers/rcar_gen3_thermal: Add support for hardware trip
points"). Only remove the 4 lines it adds to rcar_gen3_thermal_resume()
as they are redundant. Does this match your view of the revert?
Yes
Do you think the 'revert' should be backported ?
I have no strong opinion, I think it's a matter of risk :-)
There is no real harm in writing the trip points to hardware twice
during resume. On the other hand if we *know* the thermal core in the
backported kernel will always call set_trips() after the device is
resumed, then there is no harm in removing it.
Yes, I agree.
Thanks for your feedback
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
