Hi Morimoto-san,
On Fri, Jul 1, 2022 at 3:41 AM Kuninori Morimoto
<kuninori.morimoto.gx@xxxxxxxxxxx> wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
>
> AVB1 needs MODSEL6, AVB2 needs MODSEL5 settings.
> This patch adds missing MODSELx setting for these.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>
Thanks for your patch!
> --- a/drivers/pinctrl/renesas/pfc-r8a779g0.c
> +++ b/drivers/pinctrl/renesas/pfc-r8a779g0.c
> @@ -1031,23 +1033,23 @@ static const u16 pinmux_data[] = {
> /* IP0SR6 */
> PINMUX_IPSR_GPSR(IP0SR6_3_0, AVB1_MDIO),
>
> - PINMUX_IPSR_GPSR(IP0SR6_7_4, AVB1_MAGIC),
> + PINMUX_IPSR_MSEL(IP0SR6_7_4, AVB1_MAGIC, SEL_AVB1_MAGIC_1),
>
> - PINMUX_IPSR_GPSR(IP0SR6_11_8, AVB1_MDC),
> + PINMUX_IPSR_MSEL(IP0SR6_11_8, AVB1_MDC, SEL_AVB1_MDC_1),
>
> PINMUX_IPSR_GPSR(IP0SR6_15_12, AVB1_PHY_INT),
>
> PINMUX_IPSR_GPSR(IP0SR6_19_16, AVB1_LINK),
> PINMUX_IPSR_GPSR(IP0SR6_19_16, AVB1_MII_TX_ER),
>
> - PINMUX_IPSR_GPSR(IP0SR6_23_20, AVB1_AVTP_MATCH),
> - PINMUX_IPSR_GPSR(IP0SR6_23_20, AVB1_MII_RX_ER),
> + PINMUX_IPSR_MSEL(IP0SR6_23_20, AVB1_AVTP_MATCH, SEL_AVB1_AVTP_MATCH_1),
> + PINMUX_IPSR_MSEL(IP0SR6_23_20, AVB1_MII_RX_ER, SEL_AVB1_AVTP_MATCH_0),
>
> - PINMUX_IPSR_GPSR(IP0SR6_27_24, AVB1_TXC),
> - PINMUX_IPSR_GPSR(IP0SR6_27_24, AVB1_MII_TXC),
> + PINMUX_IPSR_MSEL(IP0SR6_27_24, AVB1_TXC, SEL_AVB1_TXC_1),
> + PINMUX_IPSR_MSEL(IP0SR6_27_24, AVB1_MII_TXC, SEL_AVB1_TXC_0),
Just like before, this doesn't look right to me: if TXC needs output
enable, I would expect MII_TXC to need output enable, too.
The same is true for (at least) TD[0-3].
Anyway, without hardware access it's very hard to verify what "output
enable" really means, so let's just keep it like this, and fix it up
later if needed.
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
i.e. will queue in renesas-pinctrl-for-v5.20.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
