Hi Philipp, Thank you for the review. On Mon, Jul 4, 2022 at 10:19 AM Philipp Zabel <p.zabel@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > On So, 2022-07-03 at 20:40 +0100, Lad Prabhakar wrote: > > Add a driver for the Renesas RZ/G2L Interrupt Controller. > > > > This supports external pins being used as interrupts. It supports > > one line for NMI, 8 external pins and 32 GPIO pins (out of 123) > > to be used as IRQ lines. > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > --- > > drivers/irqchip/Kconfig | 8 + > > drivers/irqchip/Makefile | 1 + > > drivers/irqchip/irq-renesas-rzg2l.c | 393 ++++++++++++++++++++++++++++ > > 3 files changed, 402 insertions(+) > > create mode 100644 drivers/irqchip/irq-renesas-rzg2l.c > > > > diff --git a/drivers/irqchip/irq-renesas-rzg2l.c b/drivers/irqchip/irq-renesas-rzg2l.c > > new file mode 100644 > > index 000000000000..4e977fa04bbe > > --- /dev/null > > +++ b/drivers/irqchip/irq-renesas-rzg2l.c > > @@ -0,0 +1,393 @@ > [...] > > +static int rzg2l_irqc_init(struct device_node *node, struct device_node *parent) > > +{ > [...] > > + resetn = devm_reset_control_get_exclusive(&pdev->dev, NULL); > > + if (IS_ERR(resetn)) > > + return IS_ERR(resetn); > > return PTR_ERR(resetn); > Oops, I will fix that and post a v8. Cheers, PRabhakar