Re: [PATCH net-next v2] dt-bindings: net: dsa: renesas,rzn1-a5psw: add interrupts description

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Le Fri, 1 Jul 2022 09:45:51 +0200,
Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> a écrit :

> Hi Clément,
> 
> On Thu, Jun 30, 2022 at 6:26 PM Clément Léger <clement.leger@xxxxxxxxxxx> wrote:
> > Describe the switch interrupts (dlr, switch, prp, hub, pattern) which
> > are connected to the GIC.
> >
> > Signed-off-by: Clément Léger <clement.leger@xxxxxxxxxxx>
> > ---
> > Changes in V2:
> >  - Fix typo in interrupt-names property.  
> 
> Thanks for the update!
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> but some suggestions below.
> 
> > --- a/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> > +++ b/Documentation/devicetree/bindings/net/dsa/renesas,rzn1-a5psw.yaml
> > @@ -26,6 +26,22 @@ properties:
> >    reg:
> >      maxItems: 1
> >
> > +  interrupts:
> > +    items:
> > +      - description: DLR interrupt  
> 
> Device Level Ring (DLR) interrupt?
> 
> > +      - description: Switch interrupt
> > +      - description: PRP interrupt  
> 
> Parallel Redundancy Protocol (PRP) interrupt?
> 
> > +      - description: Integrated HUB module interrupt
> > +      - description: RX Pattern interrupt  
> 
> Receive Pattern Match interrupt?

Hi Geert,

I'll modify that and send a V3, thanks for your comments !

> 
> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                 -- Linus Torvalds



-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux