On 29/06/2022 20:48, Geert Uytterhoeven wrote: >> >> You sure? Except rebasing I don't see that. rpcif_sw_init() received the >> rpcif so it had access to all fields. > > Yes I am, don't be misguided by the name of the local variable. > The rpcif structure is allocated by the HF or SPI child driver, > and thus not available in the RPC core driver's .probe() function. > The rpc_priv structure (as of patch 4) is allocated by the RPC core driver. > >>> I agree patches 1-3 could be moved later, if you think it is worthwhile. >> >> This would not be enough, it has to be first patch to be backportable. > > I can make it second? ;-) Why? The point is that this commit should have Fixes or Cc-stable tag. If you make it depending on other non-backportable commit, stable folks cannot pull it automatically. > Note that that still precludes (easily) backporting s2ram support. But S2R is a feature so it won't be backported... Best regards, Krzysztof
