Re: [kms-test] [PATCH 03/10] tests: allplanes: Log the plane IDs

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Quoting Laurent Pinchart (2022-06-10 00:40:24)
> Plane IDs are useful for debugging, log them.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
>  tests/kms-test-allplanes.py | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms-test-allplanes.py b/tests/kms-test-allplanes.py
> index 0fe6cfab0a2d..96ac4f19f538 100755
> --- a/tests/kms-test-allplanes.py
> +++ b/tests/kms-test-allplanes.py
> @@ -46,7 +46,8 @@ class AllPlanesTest(kmstest.KMSTest):
>                  continue
>  
>              self.logger.log(f'Testing connector {connector.fullname}, CRTC {crtc.id}, '
> -                            f'mode {mode.name} with {len(planes)} planes')
> +                            f'mode {mode.name} with {len(planes)} planes '
> +                            f'(P: {crtc.primary_plane.id}, O: {[plane.id for plane in planes]})')

Is P plane / Primary ? And O ... Other ?

either way, it's debug info that's helpful (and I hope more obvious) to
the reader at runtime.


Reviewed-by: Kieran Bingham <kieran.bingham@xxxxxxxxxxxxxxxx>

>  
>              # Create a frame buffer
>              fb = pykms.DumbFramebuffer(self.card, mode.hdisplay, mode.vdisplay, 'XR24')
> -- 
> Regards,
> 
> Laurent Pinchart
>




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux