Hi Geert-san,
> From: Geert Uytterhoeven, Sent: Tuesday, June 28, 2022 4:50 PM
>
> Hi Shimoda-san,
>
> On Mon, Jun 27, 2022 at 2:24 PM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@xxxxxxxxxxx> wrote:
> > Add R-Car Gen4 PCIe Endpoint support. This controller is based on
> > Synopsys DesignWare PCIe.
> >
> > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>
> Thanks for your patch!
Thank you for your review!
> > --- /dev/null
> > +++ b/drivers/pci/controller/dwc/pcie-rcar-gen4-ep.c
>
> > +static int rcar_gen4_pcie_ep_probe(struct platform_device *pdev)
> > +{
> > + struct device *dev = &pdev->dev;
> > + struct rcar_gen4_pcie *rcar;
> > + int err;
> > +
> > + rcar = rcar_gen4_pcie_devm_alloc(dev);
> > + if (!rcar)
> > + return -ENOMEM;
> > +
> > + err = rcar_gen4_pcie_pm_runtime_enable(dev);
> > + if (err < 0) {
> > + dev_err(dev, "pm_runtime_get_sync failed\n");
>
> The error message doesn't match the function called
> (same for patch 9/13).
Oops. Thank you for pointing it out.
> As this is abstracted, perhaps "failed to enable Runtime PM"?
I think so. But, As I mentioned on patch 9/13, if I can merge
rcar_gen4_pcie_pm_runtime_enable() into rcar_gen4_pcie_prepare(),
I'll change other error message.
Best regards,
Yoshihiro Shimoda
> > + return err;
> > + }
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
