Le Sat, 25 Jun 2022 00:43:30 +0300, Vladimir Oltean <olteanv@xxxxxxxxx> a écrit : > On Fri, Jun 24, 2022 at 04:39:45PM +0200, Clément Léger wrote: > > The Renesas RZ/N1 SoCs features an ethernet subsystem which contains > > (most notably) a switch, two GMACs, and a MII converter [1]. This > > series adds support for the switch and the MII converter. > > > > The MII converter present on this SoC has been represented as a PCS > > which sit between the MACs and the PHY. This PCS driver is probed from > > the device-tree since it requires to be configured. Indeed the MII > > converter also contains the registers that are handling the muxing of > > ports (Switch, MAC, HSR, RTOS, etc) internally to the SoC. > > > > The switch driver is based on DSA and exposes 4 ports + 1 CPU > > management port. It include basic bridging support as well as FDB and > > statistics support. > > > > Link: [1] https://www.renesas.com/us/en/document/mah/rzn1d-group-rzn1s-group-rzn1l-group-users-manual-r-engine-and-ethernet-peripherals > > > > ----- > > Changes in V9: > > - Cover letter: > > - Remove comment about RZN1 patches that are now in the master branch. > > - Commits: > > - Add Vladimir Oltean Reviewed-by > > - PCS: > > - Add "Depends on OF" for PCS_RZN1_MIIC due to error found by intel > > kernel test robot <lkp@xxxxxxxxx>. > > - Check return value of of_property_read_u32() for > > "renesas,miic-switch-portin" property before setting conf. > > - Return miic_parse_dt() return value in miic_probe() on error > > - Switch: > > - Add "Depends on OF" for NET_DSA_RZN1_A5PSW due to errors found by > > intel kernel test robot <lkp@xxxxxxxxx>. > > - DT: > > - Add spaces between switch port and '{' > > I took one more look through the series and this looks good, thanks. Hi Vladimir, Thanks for the review. Clément > > Reviewed-by: Vladimir Oltean <olteanv@xxxxxxxxx> -- Clément Léger, Embedded Linux and Kernel engineer at Bootlin https://bootlin.com
