On Fri, Jun 24, 2022 at 12:17 PM Phil Edworthy
<phil.edworthy@xxxxxxxxxxx> wrote:
>
> Yet another i2c controller from Renesas that is found on the RZ/V2M
> (r9a09g011) SoC. It can support only 100kHz and 400KHz operation.
I see nothing wrong with this, just one suggestion for a cleanup:
> +#ifdef CONFIG_PM_SLEEP
> +static int rzv2m_i2c_suspend(struct device *dev)
...> +static const struct dev_pm_ops rzv2m_i2c_pm_ops = {
> + SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(rzv2m_i2c_suspend, rzv2m_i2c_resume)
> +};
> +
> +#define DEV_PM_OPS (&rzv2m_i2c_pm_ops)
> +#else
> +#define DEV_PM_OPS NULL
> +#endif /* CONFIG_PM_SLEEP */
Remove the #ifdef here, and use the new NOIRQ_SYSTEM_SLEEP_PM_OPS()
in place of SET_NOIRQ_SYSTEM_SLEEP_PM_OPS().
Arnd
