Hi Shimoda-san, Geert, On Fri, Jun 03, 2022 at 08:05:24PM +0900, Yoshihiro Shimoda wrote: > Enable UFS device for R-Car S4-8 Spider CPU board. > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> With my firmware, the manual setup of the clock in the bootloader is still needed. So, yes, I agree we should wait with this patch until we have a better way to deal with the clock. Other than that, the patches give me SCSI disks I can work with (partition, read, write). There are a few initial errors, though: [ 0.449917] ufshcd-renesas e6860000.ufs: ufshcd_query_attr: opcode 0x03 for idn 1 failed, index 0, err = 253 [ 0.452035] ufshcd-renesas e6860000.ufs: ufshcd_query_attr: opcode 0x03 for idn 1 failed, index 0, err = 253 [ 0.453859] ufshcd-renesas e6860000.ufs: ufshcd_query_attr: opcode 0x03 for idn 1 failed, index 0, err = 253 [ 0.453874] ufshcd-renesas e6860000.ufs: ufshcd_query_attr_retry: query attribute, idn 1, failed with error 253 after 3 retires (A patch for the typo in the last line has already been sent) But after that, everything looks fine on first testing. So, for the patches: Tested-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Happy hacking!
Attachment:
signature.asc
Description: PGP signature
