Hi Phil, Thanks for your patch! On Tue, Jun 7, 2022 at 3:59 PM Phil Edworthy <phil.edworthy@xxxxxxxxxxx> wrote: > The WDT on RZ/V2M devices is basically the same as RZ/G2L, with the > exception that the RZ/V2M has a single combined interrupt, whereas the > RZ/G2L has time out and error interrupts. ... and that the RZ/V2M watchdog does not have the parity error handling. > Signed-off-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> > Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > --- a/drivers/watchdog/rzg2l_wdt.c > +++ b/drivers/watchdog/rzg2l_wdt.c > @@ -256,6 +256,7 @@ static int rzg2l_wdt_probe(struct platform_device *pdev) > > static const struct of_device_id rzg2l_wdt_ids[] = { > { .compatible = "renesas,rzg2l-wdt", }, > + { .compatible = "renesas,rzv2m-wdt", }, Hence this is not sufficient, as you need to prevent writing to the parity registers on RZ/V2M. > { /* sentinel */ } > }; Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds