Hi Wolfram, On Sat, Jun 4, 2022 at 8:58 AM Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > Extracted from a larger BSP patch made by Linh Phung. > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Thanks for your patch! > --- a/arch/arm64/boot/dts/renesas/r8a779f0.dtsi > +++ b/arch/arm64/boot/dts/renesas/r8a779f0.dtsi > @@ -355,6 +355,18 @@ dmac1: dma-controller@e7351000 { > dma-channels = <16>; > }; > > + mmc0: mmc@ee140000 { > + compatible = "renesas,sdhi-r8a779f0", > + "renesas,rcar-gen4-sdhi"; > + reg = <0 0xee140000 0 0x2000>; > + interrupts = <GIC_SPI 236 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 706>; Missing SD0H clock. Missing clock-names. > + power-domains = <&sysc R8A779F0_PD_ALWAYS_ON>; > + resets = <&cpg 706>; > + max-frequency = <200000000>; > + status = "disabled"; > + }; > + > gic: interrupt-controller@f1000000 { > compatible = "arm,gic-v3"; > #interrupt-cells = <3>; The rest LGTM. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds