Hi Wolfram, On Sun, Jun 5, 2022 at 2:34 PM Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> wrote: > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Thanks for your patch! > --- a/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > +++ b/Documentation/devicetree/bindings/mmc/renesas,sdhi.yaml > @@ -61,6 +61,10 @@ properties: > - renesas,sdhi-r9a07g044 # RZ/G2{L,LC} > - renesas,sdhi-r9a07g054 # RZ/V2L > - const: renesas,rcar-gen3-sdhi # R-Car Gen3 or RZ/G2 > + - items: > + - enum: > + - renesas,sdhi-r8a779f0 # R-Car S4-8 > + - const: renesas,rcar-gen4-sdhi # R-Car Gen4 LGTM. > > reg: > maxItems: 1 You forgot to add "renesas,rcar-gen4-sdhi" to the "if" block below, controlling clocks and clock-names. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds