Hi Wolfram, Thanks for your work. On 2022-05-25 17:12:16 +0200, Wolfram Sang wrote: > When setting up a new board, a plain "Can't register thermal zone" > didn't help me much because the thermal zones in DT were all fine. I > just had a sensor entry too much in the parent TSC node. Reword the > failure/success messages to contain the sensor number to make it easier > to understand which sensor is affected. Example output now: > > rcar_gen3_thermal e6198000.thermal: Sensor 0: Trip points loaded: 1 > rcar_gen3_thermal e6198000.thermal: Sensor 1: Trip points loaded: 1 > rcar_gen3_thermal e6198000.thermal: Sensor 2: Trip points loaded: 1 > rcar_gen3_thermal e6198000.thermal: Sensor 3: Can't register thermal zone > > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> Reviewed-by: Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx> > --- > drivers/thermal/rcar_gen3_thermal.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c > index ccdf8a24ddc7..ca5558178374 100644 > --- a/drivers/thermal/rcar_gen3_thermal.c > +++ b/drivers/thermal/rcar_gen3_thermal.c > @@ -511,7 +511,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev) > zone = devm_thermal_zone_of_sensor_register(dev, i, tsc, > &rcar_gen3_tz_of_ops); > if (IS_ERR(zone)) { > - dev_err(dev, "Can't register thermal zone\n"); > + dev_err(dev, "Sensor %u: Can't register thermal zone\n", i); > ret = PTR_ERR(zone); > goto error_unregister; > } > @@ -533,7 +533,7 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev) > if (ret < 0) > goto error_unregister; > > - dev_info(dev, "TSC%u: Loaded %d trip points\n", i, ret); > + dev_info(dev, "Sensor %u: Trip points loaded: %u\n", i, ret); > } > > if (!priv->num_tscs) { > -- > 2.35.1 > -- Kind Regards, Niklas Söderlund