Hi Ziyang,
william.xuanziyang@xxxxxxxxxx wrote on Mon, 23 May 2022 09:57:25 +0800:
> It is inconsistent IS_ERR and PTR_ERR for rtc->rtcdev in rzn1_rtc_probe().
>
> Generated by coccinelle script:
> scripts/coccinelle/tests/odd_ptr_err.cocci
>
> Fixes: deeb4b5393e1 ("rtc: rzn1: Add new RTC driver")
> Signed-off-by: Ziyang Xuan <william.xuanziyang@xxxxxxxxxx>
> ---
> drivers/rtc/rtc-rzn1.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c
> index f92d1398b0f1..4cf54af8a8c3 100644
> --- a/drivers/rtc/rtc-rzn1.c
> +++ b/drivers/rtc/rtc-rzn1.c
> @@ -348,7 +348,7 @@ static int rzn1_rtc_probe(struct platform_device *pdev)
>
> rtc->rtcdev = devm_rtc_allocate_device(&pdev->dev);
> if (IS_ERR(rtc->rtcdev))
> - return PTR_ERR(rtc);
> + return PTR_ERR(rtc->rtcdev);
Thanks for the patch, but Dan Carpenter already provided the exact same
fix.
Cheers,
Miquèl
