Re: [PATCH v5 2/6] dt-bindings: PCI: renesas,pci-rcar-gen2: Add device tree support for r9a06g032

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Hervé,

On Fri, May 20, 2022 at 10:23 AM Herve Codina <herve.codina@xxxxxxxxxxx> wrote:

> On Sun, 1 May 2022 10:51:43 +0200
> Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> [...]
> > >    resets:
> > >      maxItems: 1
> > > @@ -106,13 +106,45 @@ required:
> > >    - interrupt-map
> > >    - interrupt-map-mask
> > >    - clocks
> > > -  - resets
> > >    - power-domains
> > >    - bus-range
> > >    - "#address-cells"
> > >    - "#size-cells"
> > >    - "#interrupt-cells"
> > >
> > > +if:
> >
> > allOf.
> >
> > > +  properties:
> > > +    compatible:
> > > +      contains:
> > > +        enum:
>
> I Have an issue with this allOf.
>
> The yaml has the following structure and so has 2 AllOf:
>   ...
>   allOf:
>   - $ref: /schemas/pci/pci-bus.yaml#
>
>   properties:
>     compatible:
>   ...
>   allOf:
>   - if:
>       properties:
>         compatible:
>           contains:
>   ...
> Is having a 'allOf' for schemas inclusion and a 'allOf' for conditionnal
> parts allowed ?

Just combine them into a single "allOf".
See e.g. Documentation/devicetree/bindings/i2c/renesas,rcar-i2c.yaml.

{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux