Hi Dan, dan.carpenter@xxxxxxxxxx wrote on Thu, 19 May 2022 16:56:19 +0300: > There is a copy and paste error so this code returns the wrong variable. > > Fixes: deeb4b5393e1 ("rtc: rzn1: Add new RTC driver") The Fixes here will point to an unknown id once pulled by Linus. Otherwise Reviewed-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > --- > drivers/rtc/rtc-rzn1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/rtc/rtc-rzn1.c b/drivers/rtc/rtc-rzn1.c > index 0b4bf6e43464..ff49cedd98b8 100644 > --- a/drivers/rtc/rtc-rzn1.c > +++ b/drivers/rtc/rtc-rzn1.c > @@ -348,7 +348,7 @@ static int rzn1_rtc_probe(struct platform_device *pdev) > > rtc->rtcdev = devm_rtc_allocate_device(&pdev->dev); > if (IS_ERR(rtc->rtcdev)) > - return PTR_ERR(rtc); > + return PTR_ERR(rtc->rtcdev); > > rtc->rtcdev->range_min = RTC_TIMESTAMP_BEGIN_2000; > rtc->rtcdev->range_max = RTC_TIMESTAMP_END_2099; Thanks, Miquèl