Hi Biju, Thank you for the review. On Thu, May 12, 2022 at 6:35 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote: > > Hi Prabhakar, > > Thanks for the patch. > > > Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> > > Subject: [PATCH v3 5/5] pinctrl: renesas: pinctrl-rzg2l: Add IRQ domain to > > handle GPIO interrupt > > > > Add IRQ domian to RZ/G2L pinctrl driver to handle GPIO interrupt. > > > > GPIO0-GPIO122 pins can be used as IRQ lines but only 32 pins can be used as > > IRQ lines at given time. Selection of pins as IRQ lines is handled by IA55 > > (which is the IRQC block) which sits in between the GPIO and GIC. > > Do we need to update bindings with interrupt-cells on [1] like [2] as it act as parent for GPIO interrupts? > Yes interrupt-controller and interrupt-parent needs to be added. I'm wondering if "interrupt-cells" is not required. If the pin is an interrupt it will be passed as an GPIO. @Geert - your thoughts ? Cheers, Prabhakar
