Hi Miquel, On Thu, May 12, 2022 at 5:27 PM Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote: > On Mon, 2022-05-09 at 15:49:43 UTC, Miquel Raynal wrote: > > This NAND controller is part of a well defined power domain handled by > > the runtime PM core. Let's keep the harmony with the other RZ/N1 drivers > > and exclusively use the runtime PM API to enable/disable the clocks. > > > > We still need to retrieve the external clock rate in order to derive the > > NAND timings, but that is not a big deal, we can still do that in the > > probe and just save this value to reuse it later. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next. Without moving the pm_runtime_get_sync() call (better: pm_runtime_resume_and_get()) before the first hardware register access? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds