Hello!
On 5/9/22 5:24 PM, Phil Edworthy wrote:
> Currently, when the HW has a single interrupt, the driver uses the
> GIC, TIC, RIC0 registers to enable and disable interrupts.
> When the HW has multiple interrupts, it uses the GIE, GID, TIE, TID,
> RIE0, RID0 registers.
>
> However, other devices, e.g. RZ/V2M, have multiple irqs and only have
> the GIC, TIC, RIC0 registers.
> Therefore, split this into a separate feature.
>
> Signed-off-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx>
> Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> ---
> v2:
> - Renamed irq_en_dis_regs to irq_en_dis
> - Squashed use of GIC reg versus GIE/GID into this patch and got rid
> of separate gptp_ptm_gic feature.
> - Minor editing of the commit msg
> ---
> drivers/net/ethernet/renesas/ravb.h | 1 +
> drivers/net/ethernet/renesas/ravb_main.c | 5 +++--
> drivers/net/ethernet/renesas/ravb_ptp.c | 4 ++--
> 3 files changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/renesas/ravb.h b/drivers/net/ethernet/renesas/ravb.h
> index 08062d73df10..0ec8256f7eef 100644
> --- a/drivers/net/ethernet/renesas/ravb.h
> +++ b/drivers/net/ethernet/renesas/ravb.h
> @@ -1027,6 +1027,7 @@ struct ravb_hw_info {
> unsigned tx_counters:1; /* E-MAC has TX counters */
> unsigned carrier_counters:1; /* E-MAC has carrier counters */
> unsigned multi_irqs:1; /* AVB-DMAC and E-MAC has multiple irqs */
> + unsigned irq_en_dis_regs:1; /* Has separate irq enable and disable regs */
You forgot to actually rename it. ;-)
> unsigned gptp:1; /* AVB-DMAC has gPTP support */
> unsigned ccc_gac:1; /* AVB-DMAC has gPTP support active in config mode */
> unsigned nc_queues:1; /* AVB-DMAC has RX and TX NC queues */
[...]
> diff --git a/drivers/net/ethernet/renesas/ravb_ptp.c b/drivers/net/ethernet/renesas/ravb_ptp.c
> index c099656dd75b..a7726c2ed594 100644
> --- a/drivers/net/ethernet/renesas/ravb_ptp.c
> +++ b/drivers/net/ethernet/renesas/ravb_ptp.c
I think you missed the check in ravb_ptp_extts()...
[...]
MBR, Sergey
