Hi Sergey,
On 04 May 2022 21:40 Sergey Shtylyov wrote:
> On 5/4/22 5:54 PM, Phil Edworthy wrote:
>
> > When the HW has a single interrupt, the driver currently uses the
> > PTME (Presentation Time Match Enable) bit in the GIC register to
> > enable/disable the PTM irq. Otherwise, it uses the GIE/GID registers.
> >
> > However, other SoCs, e.g. RZ/V2M, have multiple irqs and use the GIC
> > register PTME bit, so separate it out as it's own feature.
> >
> > Signed-off-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx>
> > Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > ---
> > drivers/net/ethernet/renesas/ravb.h | 1 +
> > drivers/net/ethernet/renesas/ravb_main.c | 1 +
> > drivers/net/ethernet/renesas/ravb_ptp.c | 4 ++--
> > 3 files changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/net/ethernet/renesas/ravb.h
> b/drivers/net/ethernet/renesas/ravb.h
> > index 08062d73df10..15aa09d93ff0 100644
> > --- a/drivers/net/ethernet/renesas/ravb.h
> > +++ b/drivers/net/ethernet/renesas/ravb.h
> > @@ -1029,6 +1029,7 @@ struct ravb_hw_info {
> > unsigned multi_irqs:1; /* AVB-DMAC and E-MAC has multiple
> irqs */
> > unsigned gptp:1; /* AVB-DMAC has gPTP support */
> > unsigned ccc_gac:1; /* AVB-DMAC has gPTP support active in
> config mode */
> > + unsigned gptp_ptm_gic:1; /* gPTP enables Presentation Time
> Match irq via GIC */
>
> I think this needs to be controlled by the 'irq_en_dis' feature bit
> from the patch #4.
Good point, I'll fix and squash the two patches.
Thanks
Phil
