Hi Geert, > Subject: Re: [PATCH] iio: adc: rzg2l_adc: Add support for RZ/G2UL ADC > > Hi Biju, > > On Tue, May 3, 2022 at 10:05 AM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > wrote: > > > Subject: Re: [PATCH] iio: adc: rzg2l_adc: Add support for RZ/G2UL > > > ADC On Tue, May 3, 2022 at 9:47 AM Biju Das > > > <biju.das.jz@xxxxxxxxxxxxxx> > > > wrote: > > > > > Subject: Re: [PATCH] iio: adc: rzg2l_adc: Add support for > > > > >RZ/G2UL ADC On Tue, May 3, 2022 at 8:54 AM Biju Das These can > > > > >be dropped, as dtbs_check should take care of that. > > > > > > > > OK, Will remove this. > > > > > > Actually it's OK to keep them, as they are the upper limits > > > supported by the hardware block. > > > > You mean use upper limit of 2 for RZ/G2UL and 8 for RZ/G2L, right? > > No, I did mean RZG2L_ADC_MAX_CHANNELS, which is the upper limit of the > hardware block. OK, Thanks for clarification. > > > For eg:- > > If we use, Channel0 and channel 2 :- this will be caught in dtbs as > > > > /home/biju/rzg2l-linux/Documentation/devicetree/bindings/iio/adc/renes > > as,rzg2l-adc.example.dtb: adc@10059000: channel@2:reg:0:0: 2 is > > greater than the maximum of 1 > > > > But for run time, we don't want to this to happen for RZ/G2UL?? > > It will be caught at "make dtbs_check" time. > And at test time, as it won't work anyway --- do not post un-tested > patches ;-) OK, I will send V2 with this removed. https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/iio/adc/rzg2l_adc.c?h=v5.18-rc5#n263 Regards, Biju
