> -----Original Message-----
> From: Biju Das
> Sent: 02 May 2022 14:10
> To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>; Michael Walle
> <michael@xxxxxxxx>
> Cc: Chris Paterson <Chris.Paterson2@xxxxxxxxxxx>; biju.das@xxxxxxxxxxxxxx;
> geert+renesas@xxxxxxxxx; linux-mtd@xxxxxxxxxxxxxxxxxxx; linux-renesas-
> soc@xxxxxxxxxxxxxxx; miquel.raynal@xxxxxxxxxxx; p.yadav@xxxxxx; Prabhakar
> Mahadev Lad <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>; richard@xxxxxx;
> tudor.ambarus@xxxxxxxxxxxxx; vigneshr@xxxxxx
> Subject: RE: [RFC] mtd: spi-nor: Add Renesas AT25QL128A serial nor flash
>
> > Subject: RE: [RFC] mtd: spi-nor: Add Renesas AT25QL128A serial nor
> > flash
> >
> > Hi Michael Walle,
> >
> > Thanks for the feedback.
> >
> > > Subject: Re: [RFC] mtd: spi-nor: Add Renesas AT25QL128A serial nor
> > > flash
> > >
> > > > drivers/mtd/spi-nor/Makefile | 1 +
> > > > drivers/mtd/spi-nor/core.c | 1 +
> > > > drivers/mtd/spi-nor/core.h | 1 +
> > > > drivers/mtd/spi-nor/renesas.c | 57
> > > > +++++++++++++++++++++++++++++++++++
> > >
> > > Please put the flash in atmel.c. There are all the Atmel/Adesto/now
> > > Renesas flashes.
> >
> > OK.
> >
> > >
> > > > +static const struct flash_info renesas_nor_parts[] = {
> > > > + { "at25ql128a", INFO(0x1f4218, 0, 64 * 1024, 256)
> > > > + NO_SFDP_FLAGS(SECT_4K | SPI_NOR_QUAD_READ) }, };
> > >
> > > I suppose this flash supports SFDP. Therefore,
> > > { "at25ql128a", PARSE_SFDP },
> > > should be enough.
> >
> > OK. I see some changes related to this in your next mail.
> >
> > >
> > > I see that the 0x1f42xx IDs are also used for the at25sl series.
> > > Could you shed some light to what the differences are? Are they
> > > compatible, do we have to distiguish between them?
For AT25QL128A flash,
0x1F:- Manufaturer
0x42:- Memory Type
0x18:- Capacity
I guess, if there is any at25sl128 flash chip, then the Capacity will be same for both the flash.
Cheers,
Biju
> > >
> > > Last, for a new flash submission we require a SFDP dump. See [1].
> > >
> > > [1]
> >
>
> Please find xxd output.
>
> biju@biju-VirtualBox:/tftpboot/RZ-G2UL$ xxd -p sfdp
> 53464450060101ff00060110300000ff1f00010280000001ffffffffffff
> ffffffffffffffffffffffffffffffffffffe520f1ffffffff0744eb086b
> 083b80bbfeffffffffff00ffffff42eb0c200f5210d800ff3362d5008429
> 01ceeca1073d7a757a75f7a2d55c19f61cffe810c080ffffffffffffffff
> ffffffffffffffff501650190000ffff
>
> > Please find the output, I did n't have xxd installed on my rootFS, so
> > used hexdump.
> >
> > root@smarc-rzg2ul:~# hexdump
> > /sys/devices/platform/soc/10060000.spi/rpc-
> > if-spi/spi_master/spi1/spi1.0/spi-nor/sfdp
> > 0000000 4653 5044 0106 ff01 0600 1001 0030 ff00
> > 0000010 001f 0201 0080 0100 ffff ffff ffff ffff
> > 0000020 ffff ffff ffff ffff ffff ffff ffff ffff
> > 0000030 20e5 fff1 ffff 07ff eb44 6b08 3b08 bb80
> > 0000040 fffe ffff ffff ff00 ffff eb42 200c 520f
> > 0000050 d810 ff00 6233 00d5 2984 ce01 a1ec 3d07
> > 0000060 757a 757a a2f7 5cd5 f619 ff1c 10e8 80c0
> > 0000070 ffff ffff ffff ffff ffff ffff ffff ffff
> > 0000080 1650 1950 0000 ffff
> > 0000088
> > root@smarc-rzg2ul:~# md5sum
> > /sys/devices/platform/soc/10060000.spi/rpc-if-
> > spi/spi_master/spi1/spi1.0/spi-nor/sfdp
> > 23e3ec56b5b8f986d0488ba4727239dd
> > /sys/devices/platform/soc/10060000.spi/rpc-if-
> > spi/spi_master/spi1/spi1.0/spi-nor/sfdp
> >
> > root@smarc-rzg2ul:~# cat
> > /sys/devices/platform/soc/10060000.spi/rpc-if-
> > spi/spi_master/spi1/spi1.0/spi-nor/jedec_id
> > 1f4218
> > root@smarc-rzg2ul:~# cat
> > /sys/devices/platform/soc/10060000.spi/rpc-if-
> > spi/spi_master/spi1/spi1.0/spi-nor/partname
> > at25ql128a
> > root@smarc-rzg2ul:~# cat
> > /sys/devices/platform/soc/10060000.spi/rpc-if-
> > spi/spi_master/spi1/spi1.0/spi-nor/manufacturer
> > renesas
> > root@smarc-rzg2ul:~#
> >
> >
> > >
> > > > +static void renesas_nor_default_init(struct spi_nor *nor) {
> > > > + nor->flags |= SNOR_F_HAS_LOCK;
> > >
> > > Did you test locking?
> >
> > No, I haven't tested locking. Will remove it.
> >
> > Cheers,
> > Biju
