Le Fri, 29 Apr 2022 16:34:57 +0200,
Clément Léger <clement.leger@xxxxxxxxxxx> a écrit :
> +
> +static struct miic_port *phylink_pcs_to_miic_port(struct phylink_pcs *pcs)
> +{
> + return container_of(pcs, struct miic_port, pcs);
> +}
> +
> +static void miic_reg_writel(struct miic *miic, int offset, u32 value)
> +{
> + writel(value, miic->base + offset);
> +
> + pr_err("Udpdating MIIC register %d with val %x\n", offset, value);
Spurious error message.
> +
> +static void miic_link_up(struct phylink_pcs *pcs, unsigned int mode,
> + phy_interface_t interface, int speed, int duplex)
> +{
> + struct miic_port *miic_port = phylink_pcs_to_miic_port(pcs);
> + struct miic *miic = miic_port->miic;
> + int port = miic_port->port;
> + u32 conv_speed = 0, val = 0;
Missing reverse christmas tree declaration.
> +
> +static void miic_dump_conf(struct device *dev,
> + s8 conf[MIIC_MODCTRL_CONF_CONV_NUM])
> +{
> + int i;
> + const char *conf_name;
Ditto.
--
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com
