Hi Geert,
> Subject: [PATCH v2 2/3] arm64: dts: renesas: rzg2ul-smarc: Enable Audio
>
> Enable Audio on RZ/G2LC SMARC EVK by adding ssi1 pincontrol entries to the
> soc-pinctrl dtsi and ssi1 and cpu sound_dai nodes to the board dtsi.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> ---
> v1->v2:
> * started using cpu_dai node instead of snd_rzg2l in board dtsi.
> * Added rb tag from Geert.
> ---
> .../dts/renesas/rzg2ul-smarc-pinfunction.dtsi | 7 ++++++
> arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi | 23 +++++++++++++++++++
> 2 files changed, 30 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/renesas/rzg2ul-smarc-pinfunction.dtsi
> b/arch/arm64/boot/dts/renesas/rzg2ul-smarc-pinfunction.dtsi
> index 17527184ff2a..201b70150e01 100644
> --- a/arch/arm64/boot/dts/renesas/rzg2ul-smarc-pinfunction.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc-pinfunction.dtsi
> @@ -98,4 +98,11 @@ sound_clk_pins: sound_clk {
> pins = "AUDIO_CLK1", "AUDIO_CLK2";
> input-enable;
> };
> +
> + ssi1_pins: ssi1 {
> + pinmux = <RZG2L_PORT_PINMUX(3, 0, 2)>, /* BCK */
> + <RZG2L_PORT_PINMUX(3, 1, 2)>, /* RCK */
> + <RZG2L_PORT_PINMUX(3, 2, 2)>, /* TXD */
> + <RZG2L_PORT_PINMUX(3, 3, 2)>; /* RXD */
> + };
> };
> diff --git a/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi
> b/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi
> index d75ad79ba804..a97c8781d223 100644
> --- a/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi
> @@ -25,6 +25,10 @@ &canfd {
> /delete-property/ pinctrl-names;
> status = "disabled";
> };
> +#else
> +&cpu_dai {
> + sound-dai = <&ssi1>;
> +};
> #endif
Looks like this guarding is not required. As below one take care of it.
Will send V3.
>
> &i2c1 {
> @@ -35,6 +39,25 @@ wm8978: codec@1a {
> };
> };
>
> +#if (SW_ET0_EN_N)
> +&ssi1 {
> + pinctrl-0 = <&ssi1_pins>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +};
> +#else
> +&snd_rzg2l {
> + status = "disabled";
> +};
> +
> +&ssi1 {
> + /delete-property/ pinctrl-0;
> + /delete-property/ pinctrl-names;
> + status = "disabled";
> +};
> +#endif
> +
> &vccq_sdhi1 {
> gpios = <&pinctrl RZG2L_GPIO(6, 1) GPIO_ACTIVE_HIGH>; };
> --
> 2.25.1
