Hi Geert,
Thanks for the feedback.
> -----Original Message-----
> From: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>
> Sent: 28 April 2022 14:54
> To: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Cc: Rob Herring <robh+dt@xxxxxxxxxx>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@xxxxxxxxxx>; Geert Uytterhoeven
> <geert+renesas@xxxxxxxxx>; Magnus Damm <magnus.damm@xxxxxxxxx>; Linux-
> Renesas <linux-renesas-soc@xxxxxxxxxxxxxxx>; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS <devicetree@xxxxxxxxxxxxxxx>; Chris
> Paterson <Chris.Paterson2@xxxxxxxxxxx>; Biju Das
> <biju.das@xxxxxxxxxxxxxx>; Prabhakar Mahadev Lad <prabhakar.mahadev-
> lad.rj@xxxxxxxxxxxxxx>
> Subject: Re: [PATCH 09/13] arm64: dts: renesas: rzg2ul-smarc: Enable Audio
>
> Hi Biju,
>
> On Mon, Apr 25, 2022 at 7:06 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> wrote:
> > Enable Audio on RZ/G2LC SMARC EVK by adding ssi1 pincontrol entries to
> > the soc-pinctrl dtsi and ssi1 and cpu_dai nodes to the board dtsi.
> >
> > Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
>
> Thanks for your patch!
>
> > --- a/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/rzg2ul-smarc.dtsi
> > @@ -27,6 +27,31 @@ wm8978: codec@1a {
> > };
> > };
> >
> > +#if (SW_ET0_EN_N)
> > +&snd_rzg2l {
> > + cpu_dai: simple-audio-card,cpu {
>
> You can just refer to &cpu_dai instead?
OK, will fix this.
Cheers,
Biju
>
> > + sound-dai = <&ssi1>;
> > + };
> > +};
>
> The rest LGTM, so
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
