Hi Biju,
Thanks for your patch!
On Mon, Apr 25, 2022 at 7:06 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> On RZ/G2{L,LC} SoM module, ssi0 is connected to wm8978 audio codec whereas
> on RZ/G2UL it is connected to ssi1. So move ssi0 and cpu sound_dai nodes
> from common dtsi to soc specific dtsi.
The first sentence reads a bit odd. Perhaps:
On RZ/G2{L,LC} SoM module, the wm8978 audio codec is connected
to ssi0, whereas on RZ/G2UL it is connected to ssi1.
?
> --- a/arch/arm64/boot/dts/renesas/rz-smarc-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rz-smarc-common.dtsi
> @@ -52,7 +52,6 @@ snd_rzg2l: sound {
> "Mic Bias", "Microphone Jack";
>
> cpu_dai: simple-audio-card,cpu {
> - sound-dai = <&ssi0>;
> };
>
> codec_dai: simple-audio-card,codec {
> --- a/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc.dtsi
> @@ -49,6 +49,19 @@ &scif2 {
> };
> #endif
>
> +&snd_rzg2l {
> + cpu_dai: simple-audio-card,cpu {
Why not refer to &cpu_dai instead?
> + sound-dai = <&ssi0>;
> + };
> +};
> +
> +&ssi0 {
> + pinctrl-0 = <&ssi0_pins>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +};
> +
> &vccq_sdhi1 {
> gpios = <&pinctrl RZG2L_GPIO(39, 1) GPIO_ACTIVE_HIGH>;
> };
> diff --git a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> index 74a844ea7537..522cfab69db6 100644
> --- a/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> +++ b/arch/arm64/boot/dts/renesas/rzg2lc-smarc.dtsi
> @@ -91,6 +91,19 @@ &scif1 {
> };
> #endif
>
> +&snd_rzg2l {
> + cpu_dai: simple-audio-card,cpu {
&cpu_dai?
> + sound-dai = <&ssi0>;
> + };
> +};
> +
> +&ssi0 {
> + pinctrl-0 = <&ssi0_pins>;
> + pinctrl-names = "default";
> +
> + status = "okay";
> +};
> +
> #if (SW_RSPI_CAN)
> &spi1 {
> /delete-property/ pinctrl-0;
The rest LGTM.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
