Hi Phil, On Wed, Apr 27, 2022 at 8:53 PM Phil Edworthy <phil.edworthy@xxxxxxxxxxx> wrote: > On 26 April 2022 19:13 Geert Uytterhoeven wrote: > > On Wed, Mar 30, 2022 at 5:42 PM Phil Edworthy wrote: > > > Details of the SoC can be found here: > > > https://www.renesas.com/us/en/products/microcontrollers- > > microprocessors/rz-cortex-a-mpus/rzv2m-dual-cortex-a53-lpddr4x32bit-ai- > > accelerator-isp-4k-video-codec-4k-camera-input-fhd-display-output > > > > > > Signed-off-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> > > > Reviewed-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx> > > > > Thanks for your patch! > > > > > --- /dev/null > > > +++ b/arch/arm64/boot/dts/renesas/r9a09g011.dtsi > > > + timer { > > > + compatible = "arm,armv8-timer"; > > > + interrupts-extended = <&gic GIC_PPI 13 > > (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>, > > > + <&gic GIC_PPI 14 > > (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>, > > > + <&gic GIC_PPI 11 > > (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>, > > > + <&gic GIC_PPI 10 > > (GIC_CPU_MASK_SIMPLE(1) | IRQ_TYPE_LEVEL_LOW)>; > > > + clocks = <&cpg CPG_MOD R9A09G011_SYC_CNT_CLK>; > > > + clock-names = "clk"; > > > + resets = <&cpg R9A09G011_SYC_RST_N>; > > > > The three properties above are not document, causing the following > > "make dtbs_check" error message: > > > > arch/arm64/boot/dts/renesas/r9a09g011-v2mevk2.dtb: timer: > > 'clock-names', 'clocks', 'resets' do not match any of the regexes: > > 'pinctrl-[0-9]+' > > From schema: > > Documentation/devicetree/bindings/timer/arm,arch_timer.yaml > Right. > I assume the correct action is to update the bindings, right? Yes. > Of course, not much will work without this clock enabled ;) And that's why you have it (rightfully) marked as a critical clock in the clock driver. > Btw, do you know of a way to run "make dtbs_check" for a single dtb? "make dtbs_check" only runs checks on DTBs created by "make dtbs". Hence make sure your .config has only CONFIG_ARCH_R9A09G011 enabled? Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
