Hi Biju,
On Tue, Apr 19, 2022 at 8:18 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
> Document VSPD found in RZ/G2L SoC. VSPD block is similar to VSP2-D
> found on R-Car SoC's, but it does not have a version register and
> it has 3 clocks compared to 1 clock on vsp1 and vsp2.
>
> This patch introduces a new compatible 'renesas,r9a07g044-vsp2' to
> handle these differences.
>
> Signed-off-by: Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxx>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> v7->v8:
Thanks for the update!
> * Added Clock-names to false for Non RZ/G2L SoC's
> * Replaced compatble 'renesas,rzg2l-vsp2'->'renesas,r9a07g044-vsp2'
Don't you want to keep "renesas,rzg2l-vsp2" as a fallback...
> --- a/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> +++ b/Documentation/devicetree/bindings/media/renesas,vsp1.yaml
> @@ -17,6 +17,7 @@ description:
> properties:
> compatible:
> enum:
> + - renesas,r9a07g044-vsp2 # RZ/G2L
> - renesas,vsp1 # R-Car Gen2 and RZ/G1
> - renesas,vsp2 # R-Car Gen3 and RZ/G2
>
> @@ -50,17 +51,43 @@ required:
>
> additionalProperties: false
>
> -if:
> - properties:
> - compatible:
> - items:
> - - const: renesas,vsp1
> -then:
> - properties:
> - renesas,fcp: false
> -else:
> - required:
> - - renesas,fcp
> +allOf:
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,vsp1
> + then:
> + properties:
> + renesas,fcp: false
> + else:
> + required:
> + - renesas,fcp
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: renesas,r9a07g044-vsp2
... so you can check for "renesas,rzg2l-vsp2" here (and in the driver),
and don't have to update this check (and the driver) when adding support
for RZ/V2L later?
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
