On 11/04/2022 03:50, Tzung-Bi Shih wrote:
On Fri, Apr 08, 2022 at 10:02:05PM +0200, Jean-Jacques Hiblot wrote:
From: Phil Edworthy <phil.edworthy@xxxxxxxxxxx>
This is a driver for the standard WDT on the RZ/N1 devices. This WDT has
very limited timeout capabilities. However, it can reset the device.
To do so, the corresponding bits in the SysCtrl RSTEN register need to
be enabled. This is not done by this driver.
Signed-off-by: Phil Edworthy <phil.edworthy@xxxxxxxxxxx>
Signed-off-by: Jean-Jacques Hiblot <jjhiblot@xxxxxxxxxxxxxxx>
With a minor comment:
Reviewed-by: Tzung-Bi Shih <tzungbi@xxxxxxxxxx>
Thanks for the time you took reviewing this.
+static int rzn1_wdt_probe(struct platform_device *pdev)
+{
[...]
+ wdt->wdtdev.timeout = DEFAULT_TIMEOUT;
+ ret = watchdog_init_timeout(&wdt->wdtdev, 0, dev);
Could it drop the assignment if `ret` is unused?
I'll keep the assignment but check the value: watchdog_timeout_invalid()
will return an error if the dt supplied value is out of range.
JJ
