On 12/04/2022 09:36, Yoshihiro Shimoda wrote:
> Document Renesas R-Car UFS host controller for R-Car S4-8 (r8a779f0).
>
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> ---
> .../devicetree/bindings/ufs/renesas,ufs.yaml | 63 +++++++++++++++++++
> 1 file changed, 63 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/ufs/renesas,ufs.yaml
>
Thank you for your patch. There is something to discuss/improve.
> +allOf:
> + - $ref: ufs-common.yaml
> +
> +properties:
> + compatible:
> + items:
No items, so just "const: renesas,...."
> + - const: renesas,r8a779f0-ufs
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 2
> +
> + clock-names:
> + maxItems: 2
No need for maxItems. Please test your bindings with dt_binding_check,
because you should see a warning about it, AFAIR.
> + items:
> + - const: fck
> + - const: ref_clk
> +
> + power-domains:
> + maxItems: 1
> +
> + resets:
> + maxItems: 1
> +
No phys. Are you sure you don't need one?
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - power-domains> + - resets
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/r8a779f0-cpg-mssr.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/power/r8a779f0-sysc.h>
> +
> + ufs: scsi@e686000 {
Node name "ufs".
Best regards,
Krzysztof
