On Sat, Apr 09, 2022 at 03:33:49PM +0200, Krzysztof Kozlowski wrote: > On 08/04/2022 17:39, Andy Shevchenko wrote: > > On Fri, Apr 08, 2022 at 05:22:21PM +0200, Krzysztof Kozlowski wrote: > >> On 01/04/2022 12:35, Andy Shevchenko wrote: > >>> Switch the code to use for_each_gpiochip_node() helper. > > > > (...) > > > >>> /* > >>> * Iterate over all driver pin banks to find one matching the name of node, > >>> * skipping optional "-gpio" node suffix. When found, assign node to the bank. > >>> */ > >>> -static void samsung_banks_of_node_get(struct device *dev, > >>> - struct samsung_pinctrl_drv_data *d, > >>> - struct device_node *node) > >>> +static void samsung_banks_node_get(struct device *dev, struct samsung_pinctrl_drv_data *d) > >> > >> This is worth simplification anyway, so please split it to separate patch. > > > > Not sure what to do and why it worth an additional churn. > > Makes this change smaller so it's easier to review. https://git.kernel.org/pub/scm/linux/kernel/git/andy/linux-gpio-intel.git/log/?h=review-andy That's how it looks like. Tell me if it is what you have had in mind. -- With Best Regards, Andy Shevchenko
