On 02/04/2022 21:37, Biju Das wrote:
> Hi Krzysztof Kozlowski,
>
> Thanks for the feedback.
>
>> Subject: Re: [PATCH v4 4/5] arm64: dts: renesas: Add initial DTSI for
>> RZ/G2UL SoC
>>
>> On 02/04/2022 09:30, Biju Das wrote:
>>> Add initial DTSI for RZ/G2UL SoC.
>>>
(...)
>>> + soc: soc {
>>> + compatible = "simple-bus";
>>> + interrupt-parent = <&gic>;
>>> + #address-cells = <2>;
>>> + #size-cells = <2>;
>>> + ranges;
>>> +
>>> + ssi0: ssi@10049c00 {
>>> + reg = <0 0x10049c00 0 0x400>;
>>> + #sound-dai-cells = <0>;
>>> + /* place holder */
>>
>> Here and in other place holders - why there are no compatibles here?
>
> These interface are not tested with mainline kernel and will be added later after testing.
>
>> What do you hold place for
>
> As mentioned in commit description, I will get compilation error as the carrier board shared
> with other SoC's For eg:- RZ/G2L,RZ/G2LC and RZ/V2L.
>
OK, thanks for explanation. It looks a bit fragile, because it means
that your rz-smarc-common.dtsi enables nodes which are not described.
Although I see the point why it's done like this, so it's fine for me.
Best regards,
Krzysztof
