On Wed, Mar 30, 2022 at 03:20:31PM +0200, Miquel Raynal wrote: > Use the device API instead of the of_* API. > While at it move this operation outside of the if block to reduce the > indentation level. Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Cc: Emil Renner Berthing <kernel@xxxxxxxx> > Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > Signed-off-by: Miquel Raynal <miquel.raynal@xxxxxxxxxxx> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- > drivers/tty/serial/8250/8250_dw.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/tty/serial/8250/8250_dw.c b/drivers/tty/serial/8250/8250_dw.c > index 1666041513a5..b6238b9bf0b2 100644 > --- a/drivers/tty/serial/8250/8250_dw.c > +++ b/drivers/tty/serial/8250/8250_dw.c > @@ -371,9 +371,9 @@ static bool dw8250_idma_filter(struct dma_chan *chan, void *param) > static void dw8250_quirks(struct uart_port *p, struct dw8250_data *data) > { > struct device_node *np = p->dev->of_node; > + unsigned long quirks = (unsigned long)device_get_match_data(p->dev); > > if (np) { > - unsigned long quirks = (unsigned long)of_device_get_match_data(p->dev); > int id; > > /* get index of serial line, if found in DT aliases */ > -- > 2.27.0 > -- With Best Regards, Andy Shevchenko