On Wed, Mar 30, 2022 at 12:00:27PM +0200, Geert Uytterhoeven wrote: > On Tue, Mar 29, 2022 at 5:29 PM Andy Shevchenko > <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: ... > > + struct fwnode_reference_args of_args; > > fw_args? Perhaps just args as other drivers do? ... > > - chip->label = devm_kasprintf(rza1_pctl->dev, GFP_KERNEL, "%pOFn", > > - np); > > + chip->label = devm_kasprintf(rza1_pctl->dev, GFP_KERNEL, "%pfw", fwnode); > > This changes the label from e.g. "/soc/pinctrl@fcfe3000/gpio-11" to "gpio-11". Hmm... It seems other way around, i.e. it changes from the name to full name. > %pfwP? But conclusion here is correct. Good catch! ... > With the above fixed: > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Acked-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Thanks for review and testing! -- With Best Regards, Andy Shevchenko
