Hi Andy, On Tue, Mar 29, 2022 at 5:29 PM Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > The gpiochip_node_count() helper iterates over the device child nodes that > have the "gpio-controller" property set. It returns the number of such nodes > under a given device. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Thanks for your patch! > --- a/include/linux/gpio/driver.h > +++ b/include/linux/gpio/driver.h > @@ -755,4 +755,16 @@ static inline void gpiochip_unlock_as_irq(struct gpio_chip *gc, > device_for_each_child_node(dev, child) \ > if (!fwnode_property_present(child, "gpio-controller")) {} else > > +static inline unsigned int gpiochip_node_count(struct device *dev) > +{ > + struct fwnode_handle *child; > + unsigned int count; Preinitialize to zero? > + > + count = 0; > + for_each_gpiochip_node(dev, child) > + count++; > + > + return count; > +} > + > #endif /* __LINUX_GPIO_DRIVER_H */ Regardless: Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Tested-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds